Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for helper function of sql execution store #5707

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Add unit test for helper function of sql execution store #5707

merged 1 commit into from
Mar 4, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Mar 4, 2024

What changed?
Add unit test for helper function of sql execution store

Why?
Improve test coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll enabled auto-merge (squash) March 4, 2024 20:09
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e0b15-79db-4943-93cc-183034ec34d5

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 45 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.01%) to 62.927%
Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/persistence/statsComputer.go 3 94.64%
common/persistence/sql/workflowStateMaps.go 11 85.56%
service/history/execution/mutable_state_task_refresher.go 29 59.81%
Totals Coverage Status
Change from base Build 018e0adf-e9d6-41c9-849c-7abb63e59244: 0.01%
Covered Lines: 93015
Relevant Lines: 147813
💛 - Coveralls

@Shaddoll Shaddoll merged commit 384c045 into cadence-workflow:master Mar 4, 2024
17 checks passed
ketsiambaku pushed a commit to ketsiambaku/cadence that referenced this pull request Mar 6, 2024
@Shaddoll @ketsiambaku
Add unit test for helper function of sql execution store (cadence-wor…
bb66915 
…kflow#5707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylanisikdemir taylanisikdemir taylanisikdemir approved these changes

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@jakobht jakobht Awaiting requested review from jakobht

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shaddoll @coveralls @taylanisikdemir